New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add trailing slash to pathPrefix
#15993
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
snitin315
approved these changes
Jun 13, 2022
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jun 22, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.17.0` -> `8.18.0`](https://renovatebot.com/diffs/npm/eslint/8.17.0/8.18.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.18.0`](https://github.com/eslint/eslint/releases/tag/v8.18.0) [Compare Source](eslint/eslint@v8.17.0...v8.18.0) #### Features - [`a6273b8`](eslint/eslint@a6273b8) feat: account for rule creation time in performance reports ([#​15982](eslint/eslint#15982)) (Nitin Kumar) #### Bug Fixes - [`f364d47`](eslint/eslint@f364d47) fix: Make no-unused-vars treat for..of loops same as for..in loops ([#​15868](eslint/eslint#15868)) (Alex Bass) #### Documentation - [`4871047`](eslint/eslint@4871047) docs: Update analytics, canonical URL, ads ([#​15996](eslint/eslint#15996)) (Nicholas C. Zakas) - [`cddad14`](eslint/eslint@cddad14) docs: Add correct/incorrect containers ([#​15998](eslint/eslint#15998)) (Nicholas C. Zakas) - [`b04bc6f`](eslint/eslint@b04bc6f) docs: Add rules meta info to rule pages ([#​15902](eslint/eslint#15902)) (Nicholas C. Zakas) - [`1324f10`](eslint/eslint@1324f10) docs: unify the wording referring to optional exception ([#​15893](eslint/eslint#15893)) (Abdelrahman Elkady) - [`ad54d02`](eslint/eslint@ad54d02) docs: add missing trailing slash to some internal links ([#​15991](eslint/eslint#15991)) (Milos Djermanovic) - [`df7768e`](eslint/eslint@df7768e) docs: Switch to version-relative URLs ([#​15978](eslint/eslint#15978)) (Nicholas C. Zakas) - [`21d6479`](eslint/eslint@21d6479) docs: change some absolute links to relative ([#​15970](eslint/eslint#15970)) (Milos Djermanovic) - [`f31216a`](eslint/eslint@f31216a) docs: Update README team and sponsors (ESLint Jenkins) #### Build Related - [`ed49f15`](eslint/eslint@ed49f15) build: remove unwanted parallel and image-min for dev server ([#​15986](eslint/eslint#15986)) (Strek) #### Chores - [`f6e2e63`](eslint/eslint@f6e2e63) chore: fix 'replaced by' rule list ([#​16007](eslint/eslint#16007)) (Milos Djermanovic) - [`d94dc84`](eslint/eslint@d94dc84) chore: remove unused deprecation warnings ([#​15994](eslint/eslint#15994)) (Francesco Trotta) - [`cdcf11e`](eslint/eslint@cdcf11e) chore: fix versions link ([#​15995](eslint/eslint#15995)) (Milos Djermanovic) - [`d2a8715`](eslint/eslint@d2a8715) chore: add trailing slash to `pathPrefix` ([#​15993](eslint/eslint#15993)) (Milos Djermanovic) - [`58a1bf0`](eslint/eslint@58a1bf0) chore: tweak URL rewriting for local previews ([#​15992](eslint/eslint#15992)) (Milos Djermanovic) - [`80404d2`](eslint/eslint@80404d2) chore: remove docs deploy workflow ([#​15984](eslint/eslint#15984)) (Nicholas C. Zakas) - [`71bc750`](eslint/eslint@71bc750) chore: Set permissions for GitHub actions ([#​15971](eslint/eslint#15971)) (Naveen) - [`90ff647`](eslint/eslint@90ff647) chore: avoid generating subdirectories for each page on new docs site ([#​15967](eslint/eslint#15967)) (Milos Djermanovic) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1427 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
This was referenced Jul 1, 2022
eslint-github-bot
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
Dec 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
archived due to age
This issue has been archived; please open a new issue for any further discussion
chore
This change is not user-facing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
When I run
npm start
and openhttp://localhost:2023
, I'm getting:This is because eleventy redirects to
pathPrefix
, which is/docs/head
without a trailing slash, and we are now appending.html
to these URLs.I'm guessing we didn't notice this in #15967 because a redirect from
http://localhost:2023/docs
tohttp://localhost:2023/docs/
was already cached in the browser.What changes did you make? (Give an overview)
Added a trailing slash to all variants of
pathPrefix
we are using.Is there anything you'd like reviewers to focus on?
This could be done by tweaking URL rewriting logic instead, but in all examples in eleventy's docs
pathPrefix
does have a trailing slash (and the default is"/"
, not""
), so I think this is a correct solution.https://www.11ty.dev/docs/config/#deploy-to-a-subdirectory-with-a-path-prefix
https://www.11ty.dev/docs/filters/url/